Be open about where the script comes from instead of showing a checksum #6
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
jay/sysperf!6
Loading…
Reference in a new issue
No description provided.
Delete branch "claude/lucid-planck-v4zwtb"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This commit was pushed to the branch of jacboy/sysperf#5 just after that PR was merged, so it never reached
master. This PR brings it in, rebased onto the currentmaster.Why
The landing page showed the SHA-256 of
/benchas a trust signal. But the checksum came from the same server as the script: whoever could replace one could replace both. So it only proved the transfer, not the origin.Changes
Landing page: "Before you run it"
github.com/jacboy/sysperfthe site is built from, with links to that version ofbenchand to its full change history. The download-read-run command stays.diffof the script fromgetsysperf.comagainst the same commit onraw.githubusercontent.com. These are two independent sources, so to hand someone a different script, an attacker would have to compromise both.The footer also shows the commit.
/bench.sha256is still published for scripts, but no longer presented as a security feature.site/build.shGITHUB_SHA(in Actions) orgit rev-parse HEAD.benchdiffers from that commit, so the page can't name a commit it isn't serving.README
Instead of the checksum link, the same comparison command, against
master, with a note that the two can briefly differ right after a push.Testing
identical.masteralso printsidentical.bench,build.shstops with "bench differs from commit …".After merging
The Deploy site workflow publishes the new section. The commit shown on the page will be the merge commit, whose
benchis identical to the one served.Generated by Claude Code